Change in ovirt-engine[master]: core: Move Guid constants

amureini at redhat.com amureini at redhat.com
Wed Jul 3 10:39:37 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Move Guid constants
......................................................................


core: Move Guid constants

Moved the constant Guid instances to be initialized after Guid's
static fields to ensure that these Guids aren't partly initialized.

This patch addresses the FindBugs wanring
SI_INSTANCE_BEFORE_FINALS_ASSIGNED - "Static initializer for
org.ovirt.engine.core.compat.Guid creates instance before all static
final fields assigned"

Change-Id: If239587d8bddba89e19253ec1e147ef770b60e85
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16278
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If239587d8bddba89e19253ec1e147ef770b60e85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list