Change in ovirt-engine[master]: webadmin: Added sorting infrastructure to SearchableListMode...

alkaplan at redhat.com alkaplan at redhat.com
Tue Jul 9 09:55:22 UTC 2013


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: Added sorting infrastructure to SearchableListModel
......................................................................


webadmin: Added sorting infrastructure to SearchableListModel

Added comparator to SearchableListModel, which if set slightly alters
the behaviour of setItems(). If it isn't set, then the behaviour should
not be altered at all.

Changed some dependent code that assumed that getItems() returned a
List, which was a breach of the SearchableListModel interface anyway
(as items is Iterable).

Change-Id: Idadafcb33979d85b7ca332cad717b7c1ceadec4b
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
2 files changed, 45 insertions(+), 6 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15846
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idadafcb33979d85b7ca332cad717b7c1ceadec4b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list