Change in ovirt-engine[master]: webadmin: Modified EntityModelCellTable for input columns

alkaplan at redhat.com alkaplan at redhat.com
Tue Jul 9 15:32:29 UTC 2013


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: Modified EntityModelCellTable for input columns
......................................................................


webadmin: Modified EntityModelCellTable for input columns

Added support in the event handling mechanism of EntityModelCellTable
for CellTable columns that prefer to handle their own browser
event. Such columns' cells should implement EventHandlingCell, and
then implement the method handlesEvent() to decide whether they'd like
to handle a given event themselves.

For now, made ListModelListBoxCell and CheckBoxColumn handle their own
click events.

Also, changed EntityModelCellTable to only treat the selection column
checkbox as a selection switch, and let other checkboxes do their own
thing.

Change-Id: If46c72cea581d331fea030ea9f2ae2f42129f44f
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/EventHandlingCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxCell.java
4 files changed, 51 insertions(+), 3 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If46c72cea581d331fea030ea9f2ae2f42129f44f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list