Change in ovirt-engine[master]: packaging: setup: updated early statement for /api

oschreib at redhat.com oschreib at redhat.com
Mon Jul 22 08:01:28 UTC 2013


Ofer Schreiber has submitted this change and it was merged.

Change subject: packaging: setup: updated early statement for /api
......................................................................


packaging: setup: updated early statement for /api

The current proxy configuration removes Expect
headers incorrectly:

1) The 'early' statement removed by the commit
4acbcb524 is still required.

2) According to mod_headers documentation at [1],
the directive cannot be used as nested in <Location>:

"Because early directives are processed before the request
path's configuration is traversed, early headers can only
be set in a main server or virtual host context.
 Early directives cannot depend on a request path, so they
will fail in contexts such as <Directory> or <Location>"

The new implementation brings back the 'early' directive and
relocates the statement into main context.

[1] http://httpd.apache.org/docs/current/mod/mod_headers.html

Change-Id: I4dda234b7669dcd6c6eb76728a8536ba49247393
Bug-Url: https://bugzilla.redhat.com/849442
Related-To: https://bugzilla.redhat.com/979737
Signed-off-by: Alex Lourie <alourie at redhat.com>
---
M packaging/conf/ovirt-engine-proxy.conf.v2.in
1 file changed, 16 insertions(+), 8 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4dda234b7669dcd6c6eb76728a8536ba49247393
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>



More information about the Engine-commits mailing list