Change in ovirt-engine[master]: findbugs: inefficient use of String constructor

[shavivi at redhat.com]

Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: inefficient use of String constructor
......................................................................


findbugs: inefficient use of String constructor

Using the java.lang.String(String) constructor wastes
memory because the object so constructed will be functionally
indistinguishable from the String passed as a parameter.
Use the argument String directly.

findbugs reason:
Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR)

Change-Id: I96b98c508f2ca60daed60be6ec29db35c2016bb3
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UriAuthority.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidation.java
3 files changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15277
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96b98c508f2ca60daed60be6ec29db35c2016bb3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>