Change in ovirt-engine[master]: restapi: Cannot remove custom properties from a vm

alkaplan at redhat.com alkaplan at redhat.com
Thu Jun 6 13:44:58 UTC 2013


Alona Kaplan has submitted this change and it was merged.

Change subject: restapi:  Cannot remove custom properties from a vm
......................................................................


restapi:  Cannot remove custom properties from a vm

When passing <custom_properties/> to update vm, the custom properties on
the vm aren't removed.
Just when passing - <custom_properties> <custom_property/>
</custom_properties> the custom properties are removed.

The mapper shouldn't ignore the custom properties if
vm.isSetCustomProperties()==true (Even if
vm.getCustomProperties().isSetCustomProperty()==false).

Change-Id: I9ba6f59eb08bc33b0f93848f9cd1bcba360605e1
Bug-Url: https://bugzilla.redhat.com/967874
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15137
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ba6f59eb08bc33b0f93848f9cd1bcba360605e1
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list