Change in ovirt-engine[master]: findbugs: inaccurate floating point comparison

shavivi at redhat.com shavivi at redhat.com
Thu Jun 6 14:37:19 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: inaccurate floating point comparison
......................................................................


findbugs: inaccurate floating point comparison

This operation compares two floating point values for equality. Because
floating point calculations may involve rounding, calculated float and
double values may not be accurate

findbugs reason:
FE: Test for floating point equality (FE_FLOATING_POINT_EQUALITY)

Change-Id: I0a5e61d30bff34ae5e381ff861dcdf4f97c65018
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15413
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5e61d30bff34ae5e381ff861dcdf4f97c65018
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>



More information about the Engine-commits mailing list