Change in ovirt-engine[master]: core: Make GUID encoders singletons

rgolan at redhat.com rgolan at redhat.com
Fri Jun 7 11:36:45 UTC 2013


Roy Golan has submitted this change and it was merged.

Change subject: core: Make GUID encoders singletons
......................................................................


core: Make GUID encoders singletons

The GUID encoders used in LDAP operations are stateless and can be
reused, so we don't need to create a new instance each time we need
them. This patch makes them singletons.

Change-Id: If8683e90ac3a2a6c0ed129686c9e06ccb47ad82d
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DefaultLdapGuidEncoder.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPALdapGuidEncoder.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSLdapGuidEncoder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSLdapGuidEncoder.java
6 files changed, 83 insertions(+), 68 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14263
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8683e90ac3a2a6c0ed129686c9e06ccb47ad82d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list