Change in ovirt-engine[master]: findbugs: Suspicious reference comparison of Boolean values

shavivi at redhat.com shavivi at redhat.com
Wed Jun 12 09:20:48 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: Suspicious reference comparison of Boolean values
......................................................................


findbugs: Suspicious reference comparison of Boolean values

RC: Suspicious reference comparison of Boolean values (RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN)

Change-Id: I210767bb1e273caa421bf3da1b1608a7facb6621
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/RadioboxCell.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java
4 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15325
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I210767bb1e273caa421bf3da1b1608a7facb6621
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list