Change in ovirt-engine[master]: core: RegisterDiskCommand - fix and refactor CDA

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: RegisterDiskCommand - fix and refactor CDA
......................................................................


core: RegisterDiskCommand - fix and refactor CDA

The canDoAction() method of RegisterDiskCommand had bug when checking
the the storage domain type, even though CDA message was added - true
was returned.

furthermore, as false is returned when a check fails, there's no need
for else-ifs.

Change-Id: Ie96fae8717053435eb1df62217ea3c1469c4768c
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainType.java
2 files changed, 15 insertions(+), 7 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/15210
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie96fae8717053435eb1df62217ea3c1469c4768c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Chris Morrissey <cmorriss at netapp.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server