Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove Linq.VmAndPoolByNameComparer ...................................................................... engine: Remove Linq.VmAndPoolByNameComparer VmAndPoolByNameComparer is used to compare instances of either a VM or a VMPool by their getName() method. Since both these classes implement the Nameable interface NameableComparator can simply be used instead, and save both runtime type checking and the additional lines of code. Change-Id: I3c9fd116c6a3911ed70e677a86ec489ccec1ad95 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 3 files changed, 4 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c9fd116c6a3911ed70e677a86ec489ccec1ad95 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com>