Change in ovirt-engine[master]: engine: Remove Linq.StorageDomainByNameComparer

amureini at redhat.com amureini at redhat.com
Sun Jun 30 16:16:46 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Remove Linq.StorageDomainByNameComparer
......................................................................


engine: Remove Linq.StorageDomainByNameComparer

The aim of this patch is to remove Linq.StorageDomainByNameComparer and
replace all its usages with the standard NameableComparator.

In order to achieve this goal, the following was performed:
1. StorageDomain.getName() was added. In the interest of causing the
   least amount of noise, it simply delegates to the old
   getStorageName().
2. StorageDomain was changed to implement Nameable (now that it has a
   getName()) method.
3. Linq.StorageDomainByNameComparer was removed, and all its
   references were changed to use NameableComparator.

Change-Id: I68b2a9f575acd4f4f4018a8c035a9e056becad2a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
7 files changed, 21 insertions(+), 21 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68b2a9f575acd4f4f4018a8c035a9e056becad2a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list