Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session

tjelinek at redhat.com tjelinek at redhat.com
Fri Mar 1 12:27:30 UTC 2013


Tomas Jelinek has submitted this change and it was merged.

Change subject: core: Non-plugin automatic invocation of console session
......................................................................


core: Non-plugin automatic invocation of console session

This patch adds a native way of connecting to a (SPICE and VNC) console from
WA/UP using external viewer (virt-viewer) installed on client system. It is
achieved by implementing a servlet that generates a config file (with all
needed information to connect) for virt-viewer that is served to the client
afterwards.

The old way of invoking console viewer (browser plugin) is still
kept, the configuration is set in the database.

The behavior for SPICE is driven by configuration. There are three modes
of behavior:
 - Plugin - The "old" way - spice-xpi is used.
 - Native - The native client is used.
 - Auto - If plugin is installed, it is used. Otherwise "native" implementation
   is used.

As for VNC - it is set to use the native implementation by default (i.e. there
is no VNC connection info popup dialog).

Backend changes:
 - Added servlets for serving console configuration.
 - Added ClientConsoleMode to vdc_options (default setting is 'Auto') and
   modified related enums.

Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843410
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
5 files changed, 73 insertions(+), 0 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Frank Kobzik: Verified


--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list