Change in ovirt-engine[master]: frontend: Non-plugin automatic invocation of console session

[tjelinek at redhat.com]

Tomas Jelinek has submitted this change and it was merged.

Change subject: frontend: Non-plugin automatic invocation of console session
......................................................................


frontend: Non-plugin automatic invocation of console session

This patch adds a native way of connecting to a (SPICE and VNC) console from
WA/UP using external viewer (virt-viewer) installed on client system. It is
achieved by implementing a servlet that generates a config file (with all
needed information to connect) for virt-viewer that is served to the client
afterwards.

The old way of invoking console viewer (browser plugin) is still
kept, the configuration is set in the database.

The behavior for SPICE is driven by configuration. There are three modes
of behavior:
 - Plugin - The "old" way - spice-xpi is used.
 - Native - The native client is used.
 - Auto - If plugin is installed, it is used. Otherwise "native" implementation
   is used.

As for VNC - it is set to use the native implementation by default (i.e. there
is no VNC connection info popup dialog).

Frontend changes:
 - removed classes that deal with displaying VNC connection info popup
 - added SpiceNativeImpl (implements ISpice) for invoking request for
   spice client configuration file
 - renamed SpiceInterfaceImpl to SpicePluginImpl
 - added marking interfaces to these two implementations
 - added class AbstractSpice that contains common properties of ISpice
   implementations
 - added ClientConsoleMode enum for representing console mode configuration
   (Auto, Native, Plugin)

Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843410
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/IVncImpl.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceNative.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpicePlugin.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
19 files changed, 1,001 insertions(+), 972 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Frank Kobzik: Verified


--
To view, visit http://gerrit.ovirt.org/11703
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>