Change in ovirt-engine[master]: tools: Avoid errors when reading notifier.conf

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Mar 4 07:41:38 UTC 2013


Juan Hernandez has submitted this change and it was merged.

Change subject: tools: Avoid errors when reading notifier.conf
......................................................................


tools: Avoid errors when reading notifier.conf

The current mechanism that we use to read the notifier.conf file in the
notifier script generates the following error messages:

  engine-notifier.sh: line 68: declare: `#': not a valid identifier

To avoid that the condition to ignore empty lines and comment lines has
been replaced with a sed command that removes them before they are
processed by the notifier script.

Change-Id: If2670db513f6f9814feb8fe2786219f12530ea96
Bug-Url: https://bugzilla.redhat.com/911216
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/tools/src/main/shell/engine-notifier.sh
1 file changed, 3 insertions(+), 8 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2670db513f6f9814feb8fe2786219f12530ea96
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list