Change in ovirt-engine[master]: core, restapi: Alias for registered disk

amureini at redhat.com amureini at redhat.com
Thu Mar 7 11:38:15 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core,restapi: Alias for registered disk
......................................................................


core,restapi: Alias for registered disk

Change-Id I82de498fd9a8e25ed9e1dc5776f2fdf0c35b46da introduced a new
operation, registering an unregistered disk (i.e., a disk that exists on
the storage domain but not in the engine's database).

Since disk aliases are an engine concept, the registered disk did not
have an alias, which is not a legal state in the engine.

This patch allows passing an alias when registering a disk, and
auto-generates an alias ("RegisteredDisk_{YYYY-MM-DD_hh-mm-ss}") if
it is not passed.

Change-Id: I6ab17da94ff7ff16852efb3a374148dacf1135f8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RegisterDiskCommandTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java
6 files changed, 80 insertions(+), 12 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12565
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab17da94ff7ff16852efb3a374148dacf1135f8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Chris Morrissey <cmorriss at netapp.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list