Change in ovirt-engine[master]: webadmin: DiskModel - naming convention cleanup

derez at redhat.com derez at redhat.com
Thu Mar 7 11:47:45 UTC 2013


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: DiskModel - naming convention cleanup
......................................................................


webadmin: DiskModel - naming convention cleanup

DiskModel:
* Renamed variable names (Java conventions).
* Reorganized variables getters/setters (and remove redundant).
* Removed redundant call to deprecated GetDiskPresetList.
  (removed GetDiskPresetList from AsyncDataProvider).

Change-Id: Iac9d635a411a0f7d54cc0e316ac831f0823df3d0
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
6 files changed, 314 insertions(+), 495 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12579
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac9d635a411a0f7d54cc0e316ac831f0823df3d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list