Change in ovirt-engine[master]: restapi: remove unneeded fetch of template disk entity

mpastern at redhat.com mpastern at redhat.com
Mon Mar 11 14:03:06 UTC 2013


Michael Pasternak has submitted this change and it was merged.

Change subject: restapi: remove unneeded fetch of template disk entity
......................................................................


restapi: remove unneeded fetch of template disk entity

Remove unneeded call to AbstractBackendCollectionResource#getEntity from
BackendTemplateDisksResource#performRemove, as this method is already
called from AbstractBackendCollectionResource#remove before to ensure
the entity exists, and that's the only flow in which
BackendTemplateDisksResource#performRemove should be called.

Change-Id: Iae1f12ad70371127fd4dceddf302798fa8b750b4
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java
2 files changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Michael Pasternak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12928
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae1f12ad70371127fd4dceddf302798fa8b750b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>



More information about the Engine-commits mailing list