Change in ovirt-log-collector[master]: tools: fixed --version output

kroberts at redhat.com kroberts at redhat.com
Tue Mar 12 18:20:05 UTC 2013


Keith Robertson has submitted this change and it was merged.

Change subject: tools: fixed --version output
......................................................................


tools: fixed --version output

--version previously showed 1.0.0. Now it shows the package name and
version as set in configure.ac.

--local-tmp default value is now randomly generated using mkdtemp.
The directory is cleaned up if -h, --version or --help where supplied
avoiding to leave unwanted empty directories around.

Moved some other constants to config.py using configure to set them.

Change-Id: I88f53765028284221a0506efbc595b146a2bca8a
Bug-Url: https://bugzilla.redhat.com/886052
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
A build/subst.inc
M configure.ac
M src/Makefile.am
M src/__main__.py
A src/config.py.in.in
5 files changed, 94 insertions(+), 20 deletions(-)

Approvals:
  Sandro Bonazzola: Verified
  Keith Robertson: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12735
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88f53765028284221a0506efbc595b146a2bca8a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>



More information about the Engine-commits mailing list