Change in ovirt-engine[master]: webadmin, userportal: Fix compile error when using gwtdev pro...

derez at redhat.com derez at redhat.com
Fri Mar 15 18:56:25 UTC 2013


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin,userportal: Fix compile error when using gwtdev profile
......................................................................


webadmin,userportal: Fix compile error when using gwtdev profile

Trying to debug WebAdmin/UserPortal via GWT Hosted Mode:

$ mvn gwt:debug -Pgwt-admin,gwt-user,gwtdev -Dgwt.noserver=true

results in Java compilation error, since GwtCachingFilter
calls java.text.DateFormat methods that are currently not
emulated via custom java.text.DateFormat GWT override.

This patch adds no-op (empty) implementations of required
methods to fix this error.

Note that GWT overrides affect GWT Hosted Mode only;
debugging server-side module (e.g. GwtCachingFilter in
'frontend' module) as Remote Java Application attaches
to server-side JVM that is unaware of GWT overrides.

Change-Id: Ic0cc662037f13ca8c19c565ebb082b8b8b82c7bc
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java
A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/TimeZone.java
2 files changed, 20 insertions(+), 1 deletion(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0cc662037f13ca8c19c565ebb082b8b8b82c7bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list