Change in ovirt-engine[master]: webadmin, userportal: Decouple AspectJ config from gwt-plugin...

vszocs at redhat.com vszocs at redhat.com
Tue Mar 19 15:07:57 UTC 2013


Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs
......................................................................


webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs

Some people might run into problems when trying to build WebAdmin
or UserPortal (e.g. OutOfMemoryError) and therefore need to adjust
gwt-maven-plugin JVM args.

Overriding "gwt-plugin.extraJvmArgs" directly is not safe, as it
also contains AspectJ load-time weaving configuration (used to
prevent GWT compiler from pruning certain classes).

This patch includes two changes:

1. Move AspectJ-related configuration out of
   "gwt-plugin.extraJvmArgs", directly into gwt-maven-plugin's
   extraJvmArgs config element.

2. Increase MaxPermSize from 256M to 512M

With this patch, people should be able to override
"gwt-plugin.extraJvmArgs" directly, without having to edit
pom.xml file.

Change-Id: I1761efcec5197121ca97fca3a7f56aa5f1718495
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12831
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1761efcec5197121ca97fca3a7f56aa5f1718495
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list