Change in ovirt-engine[master]: gluster: Use brick server for advanced details

[sanjal at redhat.com]

Shireesh Anjal has submitted this change and it was merged.

Change subject: gluster: Use brick server for advanced details
......................................................................


gluster: Use brick server for advanced details

Currently, there is a bug in glusterfs, because of which the command
'gluster volume status' for a particular brick works properly only if
it is executed on the server where the brick resides.

While that bug gets fixed in glusterfs, I am changing the code here
to make sure that we always execute the command on the brick's server
(provided it is UP).

Another refactoring done in this patch is to expect volume and brick
IDs instead of names in GlusterVolumeAdvancedDetailsParameters

Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a
Bug-Url: https://bugzilla.redhat.com/877961
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeAdvancedDetailsParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/GlusterTestHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
11 files changed, 213 insertions(+), 129 deletions(-)

Approvals:
  Shireesh Anjal: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>