Change in ovirt-engine[master]: core: export vm/create template shouldn't include ILLEGAL di...

mlipchuk at redhat.com mlipchuk at redhat.com
Wed Mar 27 08:32:20 UTC 2013


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: export vm/create template shouldn't include ILLEGAL disks
......................................................................


core: export vm/create template shouldn't include ILLEGAL disks

When exporting a VM/Creating a template - return CDA message when there
are image disks which are in ILLEGAL status, this prevents the following:
*additional vdsm commands
*possible status change from ILLEGAL to ok
*failure of the entire operation

Change-Id: I6e608c0c87c6e3a8d275fd74658b888cde6c8694
Bug-Url: https://bugzilla.redhat.com/921489
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 57 insertions(+), 12 deletions(-)

Approvals:
  Maor Lipchuk: Looks good to me, approved
  Liron Ar: Verified


--
To view, visit http://gerrit.ovirt.org/13203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e608c0c87c6e3a8d275fd74658b888cde6c8694
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list