Change in ovirt-engine[master]: core: Remove IsVdsWithSameNameExist

amureini at redhat.com amureini at redhat.com
Sun Mar 31 05:52:24 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove IsVdsWithSameNameExist
......................................................................


core: Remove IsVdsWithSameNameExist

IsVdsWithSameNameExistQuery is not used anywhere in
the code, and hence should be removed.

This patch removes the following:
1. The IsVdsWithSameNameExistQuery class
2. The IsVdsWithSameNameExist constant representing
   it in VdcQueryType
3. The IsVdsWithSameNameExistParameters class which
   was only used by the removed query class.
3. The getByVdsName(String) method in VdsStaticDAO
   (which was only used by the query), its implementation, and its
   test.
4. The GetVdsStaticByVdsNam stored procedure
   that was only used by the said DAO function.

Change-Id: I676cca49a2cc62c7b0716589ee26d2bcffd3cbb7
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/dbscripts/vds_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameNameExistQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameNameExistParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java
7 files changed, 0 insertions(+), 98 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13290
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I676cca49a2cc62c7b0716589ee26d2bcffd3cbb7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list