Change in ovirt-engine[master]: core: broken unit test

ecohen at redhat.com ecohen at redhat.com
Wed May 1 12:29:45 UTC 2013


Einav Cohen has submitted this change and it was merged.

Change subject: core: broken unit test
......................................................................


core: broken unit test

Fixed a unit test that would break if a file didn't exist in a certain
environment.

Unit test now creates a file "on the fly" (without writing it to the
disk) and uses it rather than relying on a file that may or may not
exist on the disk.

Change-Id: I9d0627ea770a3194515b22b6d6cc5df5fe8df829
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ServletUtilsTest.java
1 file changed, 24 insertions(+), 6 deletions(-)

Approvals:
  Einav Cohen: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d0627ea770a3194515b22b6d6cc5df5fe8df829
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list