Change in ovirt-engine[master]: webadmin: User Event Notification dialog element IDs

vszocs at redhat.com vszocs at redhat.com
Thu May 2 20:00:17 UTC 2013


Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: User Event Notification dialog element IDs
......................................................................


webadmin: User Event Notification dialog element IDs

1. UI infrastructure changes

   - created ElementIdCellTree that supports assigning DOM
     element IDs to tree nodes through HasElementId interface

   - EntityModelCellTree derives from ElementIdCellTree,
     so all model-bound trees now support node element IDs

   - ModelListTreeViewModel does the actual element ID
     assignment for the CheckboxCell

   - example tree node ID, e.g. 2nd child of 3rd root node:
     <prefix>_root2_node1

2. WebAdmin dialog changes

   - User Event Notification dialog (ManageEventsPopupView)
     now supports element IDs for Tree and Expand/Collapse
     buttons

Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a
Bug-Url: https://bugzilla.redhat.com/870993
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TreeNodeModel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ColumnWithElementId.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/ElementIdCellTree.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/TreeModelWithElementId.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SimpleSelectionTreeNodeModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EntityModelCellTree.java
11 files changed, 220 insertions(+), 88 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14048
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list