Change in ovirt-engine[master]: tools: Proper error testing in EngineConfigCLITest

amureini at redhat.com amureini at redhat.com
Mon May 6 06:21:27 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: tools: Proper error testing in EngineConfigCLITest
......................................................................


tools: Proper error testing in EngineConfigCLITest

Converted the error tests in EngineConfigCLITest to the proper JUnit
form (with the expect parameter on the @Test annotation), instead of the
awkward explicit fail before the catch block.

Since the test methods have meaningful names, this change also allowed
removing the System.out.println calls.

Change-Id: Iad25eae4fd7b4535cc1b2d9570f142d6996b79d0
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigCLIParserTest.java
1 file changed, 4 insertions(+), 20 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad25eae4fd7b4535cc1b2d9570f142d6996b79d0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list