Change in ovirt-engine[master]: core: [cleanup] tiny cleanups

ofrenkel at redhat.com ofrenkel at redhat.com
Tue May 7 14:35:23 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: [cleanup] tiny cleanups
......................................................................


core: [cleanup] tiny cleanups

This patch contains:
1. change the indentation in HibernateVmCommand#getAuditLogTypeValue to
make it more readable
2. simplified AsyncTaskManager#hasTasksForEntityIdAndAction structure
3. replace ArrayList with List in VdsActionParameterBase public methods
signatures

Change-Id: I7bbfc040e06ff1cfd48ba02a5992d0d533d9e75f
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
4 files changed, 13 insertions(+), 15 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bbfc040e06ff1cfd48ba02a5992d0d533d9e75f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list