Change in ovirt-engine[master]: engine: Refactoring AddVdsCommand#canDoAction()

sanjal at redhat.com sanjal at redhat.com
Fri May 10 05:48:04 UTC 2013


Shireesh Anjal has submitted this change and it was merged.

Change subject: engine: Refactoring AddVdsCommand#canDoAction()
......................................................................


engine: Refactoring AddVdsCommand#canDoAction()

to use failCanDoAction(), saving few lines of code. Also made sure that
the gluster specific validation happens only if all previous validation
was successful.

Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602
Signed-off-by: Shireesh Anjal <anjalshireesh at gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
1 file changed, 10 insertions(+), 17 deletions(-)

Approvals:
  Shireesh Anjal: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14401
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list