Change in ovirt-engine[master]: packaging: remove bash usage from tools

oschreib at redhat.com oschreib at redhat.com
Sun May 12 11:37:33 UTC 2013


Ofer Schreiber has submitted this change and it was merged.

Change subject: packaging: remove bash usage from tools
......................................................................


packaging: remove bash usage from tools

bash usage for scripts should be discouraged in favor of POSIX sh.

remove the argument# validation as the java already validates it.

Change-Id: I40064044a6da2b1088ee5d40eff874b9f8db66c3
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/bin/engine-config.sh
M packaging/bin/engine-manage-domains.sh
M packaging/bin/engine-prolog.sh.in
M packaging/fedora/setup/engine-check-update
4 files changed, 156 insertions(+), 184 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40064044a6da2b1088ee5d40eff874b9f8db66c3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list