Change in ovirt-engine[master]: core: DirectorySearcherTest proper failures

amureini at redhat.com amureini at redhat.com
Tue May 14 06:57:33 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: DirectorySearcherTest proper failures
......................................................................


core: DirectorySearcherTest proper failures

Used the proper JUnit 4 syntax for failures - @Test with the expected
parameter, instead of the ugly hack of catching an exception and
returning before the test reaches a fail() statement.

Change-Id: Icdc729f0aa78674f45ce11aab844cbf9751a6ac6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java
1 file changed, 9 insertions(+), 31 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icdc729f0aa78674f45ce11aab844cbf9751a6ac6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list