Change in ovirt-engine[master]: core: Fix testGetRootDSENoServers

amureini at redhat.com amureini at redhat.com
Tue May 14 06:57:34 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix testGetRootDSENoServers
......................................................................


core: Fix testGetRootDSENoServers

Since urls is a zero length list, urls.get(0) throws an
IndexOutOfBoundsException.
This exception is caught, and thus the test passes, but it's kind of
meaningless - it does not execute any of the DirectorySearcher's code,
and essentially tests Java's ArrayList.get(int) implementation.

I guess it's safe to assume that it works correctly.

Change-Id: I295d9b10495efabf892107187de7ccd91334062f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14418
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I295d9b10495efabf892107187de7ccd91334062f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list