Change in ovirt-engine[master]: engine: Forbid star imports

amureini at redhat.com amureini at redhat.com
Mon May 20 13:11:11 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Forbid star imports
......................................................................


engine: Forbid star imports

By the project's conventions (which are enforced by code review) *
imports are not allowed.

This patch adds a checkstyle validation to ensure these errors are
caught at build time instead of review time.

Change-Id: I62cd280184ad2baf8ad8298b32b0a1f61d4bc0b2
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62cd280184ad2baf8ad8298b32b0a1f61d4bc0b2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list