Change in ovirt-engine[master]: packaging: setup: domain validation changes

oschreib at redhat.com oschreib at redhat.com
Tue May 21 06:55:34 UTC 2013


Ofer Schreiber has submitted this change and it was merged.

Change subject: packaging: setup: domain validation changes
......................................................................


packaging: setup: domain validation changes

1. perform reverse lookup only if AIO plugin is installed, as it is not
   required unless libvirt is trying to perform migration.

2. allow names without suffix, warn in this case.

3. split out hostname logic from protocols.

Change-Id: I7276d3e9088fd370458846bfdcee7166331935e4
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/core.py
M packaging/setup/plugins/ovirt-engine-setup/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/config/hostname.py
M packaging/setup/plugins/ovirt-engine-setup/config/protocols.py
5 files changed, 362 insertions(+), 294 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7276d3e9088fd370458846bfdcee7166331935e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>



More information about the Engine-commits mailing list