Change in ovirt-engine[master]: findbugs: ignore: Redundant null check from getConfigValue

shavivi at redhat.com shavivi at redhat.com
Sun May 26 11:08:10 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: ignore: Redundant null check from getConfigValue
......................................................................


findbugs: ignore: Redundant null check from getConfigValue

findbugs complains that we are checking ldapPort for null when its not
suppose to be null.
in this case we are checking for the return value from getConfigValue()
and we may have a null value from the Database

findbugs reason:
RCN: Redundant nullcheck of value known to be non-null

Change-Id: If712c28362bae2cfa756c14d8cadf1e96fc3e187
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/tools/exclude-filters.xml
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If712c28362bae2cfa756c14d8cadf1e96fc3e187
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>



More information about the Engine-commits mailing list