Change in ovirt-engine[master]: webadmin: Houskeeping in Provider main tab and popup

oourfali at redhat.com oourfali at redhat.com
Mon May 27 08:36:26 UTC 2013


Oved Ourfali has submitted this change and it was merged.

Change subject: webadmin: Houskeeping in Provider main tab and popup
......................................................................


webadmin: Houskeeping in Provider main tab and popup

Closed possible loopholes, removed redundant code, changed method
access modifiers, added constants to represent command names,
formatted code for uniformity within files.

Change-Id: Ie5d4225174e733588010a46325674df2165c8814
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
2 files changed, 158 insertions(+), 204 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5d4225174e733588010a46325674df2165c8814
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>



More information about the Engine-commits mailing list