Change in ovirt-engine[master]: findbugs: unsynchronized initialization of non-volatile stat...

shavivi at redhat.com shavivi at redhat.com
Thu May 30 07:51:33 UTC 2013


Shahar Havivi has submitted this change and it was merged.

Change subject: findbugs: unsynchronized initialization of non-volatile static field
......................................................................


findbugs: unsynchronized initialization of non-volatile static field

This method contains an unsynchronized lazy initialization of a
non-volatile static field. Because the compiler or processor may reorder
instructions we need to make the field volatile

findbugs reason:
LI: Incorrect lazy initialization of static field (LI_LAZY_INIT_STATIC)

Change-Id: I1e0f8e380edd20d9a9ae3f99dfb82df5736786f9
Signed-off-by: Shahar Havivi <shavivi at redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Shahar Havivi: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15180
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e0f8e380edd20d9a9ae3f99dfb82df5736786f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>



More information about the Engine-commits mailing list