Change in ovirt-engine[master]: core: quota permissions isn't enforced in add VM

gchaplik at redhat.com gchaplik at redhat.com
Wed Nov 6 09:22:15 UTC 2013


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: quota permissions isn't enforced in add VM
......................................................................


core: quota permissions isn't enforced in add VM

When creating a VM or one of the command's derivatives (add VM from .., etc.),
a consume quota check should be performed on the designated quota,
Currently when creating a VM, there isn't any permission check on that quota, the
check if performed only if the quota is consumed (i.e running a vm).

Also when running a VM there shouldn't be any quota permission check.

Change-Id: I421ac8019cf16cc6f2a18ce6b4bcbcbf83397225
Bug-Url: https://bugzilla.redhat.com/1020201
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20574
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I421ac8019cf16cc6f2a18ce6b4bcbcbf83397225
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list