Change in ovirt-engine[ovirt-engine-3.3]: webadmin: disks tab - add listeners on presenter

iheim at redhat.com iheim at redhat.com
Wed Nov 6 10:17:37 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: disks tab - add listeners on presenter
......................................................................


webadmin: disks tab - add listeners on presenter

Adding disk type (All/Image/LUN) change event lister
on 'MainTabDiskPresenter -> onReveal' in order
to ensure listener subscription (currently, since the
listeners are added in the view, it might get
cleared upon staling the list model).

Change-Id: I0a0e76d5c21c1420232b12a6cbf2d65ff2851c09
Bug-Url: https://bugzilla.redhat.com/1019659
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
2 files changed, 29 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Daniel Erez: Verified
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/20943
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a0e76d5c21c1420232b12a6cbf2d65ff2851c09
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list