Change in ovirt-engine[master]: engine: Change AuditLogableBase.customId type to string

masayag at redhat.com masayag at redhat.com
Wed Nov 6 11:51:47 UTC 2013


Moti Asayag has submitted this change and it was merged.

Change subject: engine: Change AuditLogableBase.customId type to string
......................................................................


engine: Change AuditLogableBase.customId type to string

It makes sense to support customId be a String, so the
clients of this method shouldn't take care of converting
fields such as UUID or any other complex objects into an
Integer which guarantees narrower values range.

Change-Id: Ie8d9bcb4b6aa6046025b829669b743b672fba684
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
3 files changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20919
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8d9bcb4b6aa6046025b829669b743b672fba684
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list