Change in ovirt-engine[ovirt-engine-3.3]: core: change required permissions for removing VM from expor...

iheim at redhat.com iheim at redhat.com
Wed Nov 6 17:10:37 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core: change required permissions for removing VM from export domain
......................................................................


core: change required permissions for removing VM from export domain

This patch changes the permissions which are required for removing a VM
from export domain. Until now, the user had to have import-export
permissions on the VM in order to be able to remove it from the export
domain - It was problematic in case the VM which is going to be removed
doesn't exist in the system.

>From now on, we require 'delete vm' permissions on the export domain
in order to be able to remove VMs from the export domain, which makes it
possible for everyone who has 'delete vm' permissions on the export
domain to remove those VMs, also in case they don't exist in the DB.

Change-Id: I9f63cc6e53cd082d011bbef72c6a9435b6c1620b
Bug-Url: https://bugzilla.redhat.com/1010963
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f63cc6e53cd082d011bbef72c6a9435b6c1620b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list