Change in ovirt-engine[ovirt-engine-3.3]: packaging: Avoid using the file command

iheim at redhat.com iheim at redhat.com
Tue Nov 12 15:37:01 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: packaging: Avoid using the file command
......................................................................


packaging: Avoid using the file command

There is no need to execute `file` in order to determine if a given file
is an executable, the bulitin -x test is enough.

Change-Id: I190571c5b36f08772fc795eca9fbd082ba248c04
Signed-off-by: Ofer Schreiber <oschreib at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029036
---
M packaging/dbscripts/dbfunctions.sh
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Sandro Bonazzola: Verified; Looks good to me, approved
  Yedidyah Bar David: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/21187
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I190571c5b36f08772fc795eca9fbd082ba248c04
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list