Change in mom[master]: policy: Fix balloon policy syntax and semantics

agl at us.ibm.com agl at us.ibm.com
Tue Nov 12 18:47:23 UTC 2013


Adam Litke has submitted this change and it was merged.

Change subject: policy: Fix balloon policy syntax and semantics
......................................................................


policy: Fix balloon policy syntax and semantics

This patch fixes two issues in the current balloon policy:
1) In shrink_guest, guest_free_percent should be
   min_guest_free_percent.  This was causing a runtime error for users.
2) When calculating balloon_min, we want to choose whichever number is
   higher between guest.balloon_min and the calculated value.
   Otherwise, guest.balloon_min cannot act as a floor value as it is
   intended to.

Change-Id: I8fba77bb5c42b29ab479752e335cbc11ed0a298b
Signed-off-by: Adam Litke <agl at us.ibm.com>
Reviewed-on: http://gerrit.ovirt.org/19416
Reviewed-by: Saggi Mizrahi <smizrahi at redhat.com>
Reviewed-by: Martin Sivák <msivak at redhat.com>
---
M doc/balloon.rules
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Adam Litke: Verified; Looks good to me, approved
  Martin Sivák: Looks good to me, but someone else must approve
  Saggi Mizrahi: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/19416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fba77bb5c42b29ab479752e335cbc11ed0a298b
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>



More information about the Engine-commits mailing list