Change in ovirt-engine[ovirt-engine-3.3]: core: fix of export without tasks and snapshot collapse

iheim at redhat.com iheim at redhat.com
Wed Nov 13 08:28:58 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core: fix of export without tasks and snapshot collapse
......................................................................


core: fix of export without tasks and snapshot collapse

The following patch handles the following issues:
*The loop should be performed for disks relevant to the snapshot only.

*The populated image id's list should contain only exported images.

*When exporting a vm with no created tasks and collapse, the collapse
operations should be done - otherwise we will never have the snapshots collapsed when there are no created tasks.

*The unlock of the vm should be the last step, as otherwise the vm
configuration might change during the run and yield to inconsistent
results.

Change-Id: I1bfc2761a5483d6f0b274d064cbc7e155562573f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
1 file changed, 3 insertions(+), 14 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21111
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1bfc2761a5483d6f0b274d064cbc7e155562573f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list