Change in ovirt-engine[master]: core: Fix double checking
amureini at redhat.com
amureini at redhat.com
Thu Nov 14 14:46:41 UTC 2013
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix double checking
......................................................................
core: Fix double checking
These getInstance() methods implement a double-checking scheme to
initialize the instance static member.
In order for this mechanism to operate correctly, the instance member
should be defined as volatile (see, e.g.,
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html).
Change-Id: I6beb664980766958b3127080fdb785c6e668f6a9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6beb664980766958b3127080fdb785c6e668f6a9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the Engine-commits
mailing list