Change in ovirt-engine[master]: gluster: Refactored GlusterTaskSyncJob

kmayilsa at redhat.com kmayilsa at redhat.com
Fri Nov 15 06:23:54 UTC 2013


Kanagaraj M has submitted this change and it was merged.

Change subject: gluster: Refactored GlusterTaskSyncJob
......................................................................


gluster: Refactored GlusterTaskSyncJob

Rafactored the class GlusterTaskSyncJob and moved the reusable methods
to GlusterTaskUtils class. The changes include -
1. Modified the class GlusterTaskUtils as a singleton class
2. Moved reusable code from GlusterTaskSyncJob to GlusterTaskUtils class
3. Modified the dependencies accordingly

Change-Id: I1abecae9389530324154cdc059ee717db0a61715
Signed-off-by: Shubhendu Tripathi <shtripat at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java
8 files changed, 241 insertions(+), 147 deletions(-)

Approvals:
  Kanagaraj M: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21063
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1abecae9389530324154cdc059ee717db0a61715
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list