Change in ovirt-engine[master]: core: DetachDiskFromVm - redundant checks and ctor usage

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: DetachDiskFromVm - redundant checks and ctor usage
......................................................................


core: DetachDiskFromVm - redundant checks and ctor usage

When executing DetachDiskFromVm command, the used parameters c'tor was
always called with true for "isPlugUnplug" property.
That means that the relevant checks within the command where always
relevant to that value only.

This patch removes the unneeded CDA check and move the callers of the
command to use the two parameters c'tor.

Change-Id: I48536a5baf4851c68f6d7053e4751d53a54f56a1
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
4 files changed, 6 insertions(+), 15 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48536a5baf4851c68f6d7053e4751d53a54f56a1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server