Change in ovirt-engine[ovirt-engine-3.3]: core: fix search validation of OSs

iheim at redhat.com iheim at redhat.com
Tue Nov 26 12:52:18 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core: fix search validation of OSs
......................................................................


core: fix search validation of OSs

the UI is validating the input for OSs and was mistakenly
lower casing each input.

this created a corner case where and os unique name with that had
capital letters, windows_2008_R2 was not a valid input for search.

its a false assumption to make that all osinfo unique os name are case
sensitive ATM and no point in trying to refactor that.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003804
Change-Id: I818dd4eead46402d1fb6a832786020a5458c533d
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java
2 files changed, 46 insertions(+), 11 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21707
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I818dd4eead46402d1fb6a832786020a5458c533d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list