Change in ovirt-engine[ovirt-engine-3.3]: core: MoveOrCopyDiskCommand - reduce query count

iheim at redhat.com iheim at redhat.com
Thu Nov 28 15:40:39 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core: MoveOrCopyDiskCommand - reduce query count
......................................................................


core: MoveOrCopyDiskCommand - reduce query count

When loading the vms for a disk, the vm device information is already
loaded - therefore there's no need to filter it out and then reload it
for each vm, we can use the values that were loaded during the first
query execution.

Change-Id: Ic4b15114bc72dc07de917692b60703008008ae13
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1032807
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
2 files changed, 26 insertions(+), 34 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4b15114bc72dc07de917692b60703008008ae13
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list