Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Unified VNIC update logic on VM creation

iheim at redhat.com iheim at redhat.com
Sun Oct 6 10:35:03 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: Unified VNIC update logic on VM creation
......................................................................


webadmin: Unified VNIC update logic on VM creation

Towards adding the ability to add and remove VNICs in the add/edit VM
dialogs, the VNIC logic is unified so it is the same for all kinds of
VM creation flows (e.g. from scratch, from template...); VNICs may
always be added, edited or removed.

Change-Id: Ifbd61031572a3462af46f24c64fb5bb80343f086
Bug-Url: https://bugzilla.redhat.com/1003779
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallbacks.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
5 files changed, 129 insertions(+), 241 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19833
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbd61031572a3462af46f24c64fb5bb80343f086
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list